next »

[zacaj]

Code:

if(newLine)
   newLine = !newLine

Could somebody explain this to me pls?

If it's not zero, set it to NOT itself. NOT itself if it's any number besides 0 makes it equals zero. It's the equivalent of newLine=0

Right, that's what I thought. So it's just a really bizarre thing to write... I wonder what the thought process was.

Most likely they wrote the second line first, possibly without any condition or with a different condition, and then later changed the condition without actually reading the code below it, only thinking that they knew that code needed to be run then. Or something along those lines.

Code:

if(newLine)
   newLine = !newLine

even better I forgot to tell you newLine is a boolean varible

Well it would work with any integer, right? Does it work with negatives? I've never actually checked...

[Claw]

Well it would work with any integer, right? Does it work with negatives? I've never actually checked...

Doing a boolean check on anything just checks if it is 0 (false) or non-zero (true), so yeah it should work on negatives too.

I had to think for a second looking at that code snippet but then I laughed

[Sakar]

Code:

frame = (n == 0) ? 0 : (n <= 0.25) ? 1 : (n <= 0.5) ? 2 : (n <= 0.75) ? 3 : (n <= 1) ? 4 : 4;

Found this funny

[rivon]

Oh god why... Why would anyone write such an ugly and totally unreadable piece of code?

[Sakar]

I'm still asking myself the same thing. Not sure what I was thinking when I wrote that

[Geti]

.. we use ternaries like that pretty often. helps to use more brackets.

[Fallsburg]

You use ternaries to do something like this?

Code:

frame =  min(ceil(n*4),4);

Because I think you are doing it wrong.


Also, even in that horribly convoluted way the bit

Code:

(n <= 1) ? 4 : 4

is completely unnecessary.  I mean, the rest of it is bad, but that's just horrible.

[Xienen]

Oh god why... Why would anyone write such an ugly and totally unreadable piece of code?

Is it sad that this line was immediately readable to me?  Obviously the whole thing was pointless and is not any sort of well written, but I've obviously dealt with ternaries a little too much =D

[Klaim]

This is the typical result when you first write the first condition, simple to read, then try it and find that there are special cases, so you just add some more conditions, but on test you see that you forgot those other different edge cases that depends on if you are or not in the right state, so you add some more conditions and continue like that until you get happy and move on without thinking about your future self.


Classic.

[Geti]

"You use ternaries to do something like this?"
No, we use ternaries that look similar to that to accomplish more useful things. The one pictured is hilarious but strings of ternaries aren't so bad compared to the equivalent pile of conditionals, though going above 3 or so in close proximity (or especially nested without parens) hurts readability to no end for sure.

"I mean, the rest of it is bad, but that's just horrible."
Good for a laugh though, no?

Laughed at my code this morning for a coding lab at uni. Have had a bunch of other stuff on so hadn't looked over the lab. Basic graph theory stuff about a social network.

Ended up that the two german guys were on their own "friend island", disconnected from everyone else in the graph. Not sure if it was the lecturer being a (funny) dickhead or what, but it certainly helped make frantically coding everything a little more bearable. 

[cliffski]

I was working on collision detection, and wanted to save the penetration depth (overlap) of the collision.

Code:

double penetration

Well I LOLed...

[garlandobloom]

Just fixed an if( x = y ) bug yesterday. It had been in the code for years. Surprised it hadn't caused more problems. Those are the peskiest kind of bugs. Just one equals sign difference. I only noticed because I updated MingW and now GCC warns about them.

So...good on the GCC devs for adding that warning!

[Geti]

I just had a laugh about the

Code:

double penetration;

thing again, but only by proxy.

Code:

Vec2f penetration;

.

[pixhead]

Code:

/**
 * the container class contains things that need containing
 */
Class Container
{
   //the prisoner is container within the continaer. For life.
   Object prisoner;
}

Note to self, code when drunk more often 

[Evan Balster]

I scrolled past some old templated code in my reflection system.

Code:

static const Parents NOPARENTS; //aww

awwwwww