next »

[tanner bananer]

this is my first time doing networking and im using java and i dont know why my players are only showing up on one screen,  the other two are supposed to look like the first one. I'm holing the x, y, height, and a name for each player in an object and i have a reciever class holding an arraylist of the player objects and i dunno.

[kamac]

One word: DEBUG

There's no way we could know how to fix such a specific issue without seeing any code.

[tanner bananer]

One word: DEBUG

There's no way we could know how to fix such a specific issue without seeing any code.

figured. i dunno what i need to show tho, like all my code?

i'll give ya this, it's my receiver

Code:

Thread activity = new Thread(this);
    MulticastSocket so;
    ArrayList<Pig> players;

    Receiver(MulticastSocket sock, ArrayList<Pig> players)
    {
        so = sock;
        this.players = players;
        activity.start();
    }

public void run() {
        byte[] data = new byte[1024];
        while (true)
            try {
                DatagramPacket packet = new DatagramPacket(data, data.length);
                so.receive(packet);
                String mess = new String(data, 0, packet.getLength());
                Scanner get = new Scanner(mess);
                String name = get.next();
                Double x = get.nextDouble();
                Double y = get.nextDouble();
                Double h = get.nextDouble();
                boolean here = false;
                for(int i = 0;i<players.size();i++)
                {
                    if(name.equals(players.get(i).name))
                    {
                        here = true;
                        players.get(i).x=x;
                        players.get(i).y=y;
                        players.get(i).h=h;
                    }
                }
                if(!here)
                {
                    players.add(new Pig(x,y,h,name));
                }
            }
            catch (IOException e) {break;}
    }

and this is in my initialize method

Code:

        try{iadr = InetAddress.getLocalHost();}catch(UnknownHostException e){}
        try{so = new MulticastSocket(port);}catch(IOException e){}
        try{so.joinGroup(iadr);}catch(IOException e){}
        new Receiver(so,players);

and Pig is the name of the player class

[oahda]

Maybe the code that's supposed to be drawing the characters.

[tanner bananer]

Maybe the code that's supposed to be drawing the characters.

the draw function is in the player class and it's working as much as that method would show

this is proly what u want

Code:

for(int j = 0;j<players.size();j++)
                {
                    if((int)(players.get(j).y/size) == i)players.get(j).draw(g,x,y,h,spaces[(int)(players.get(j).x/size)][(int)(players.get(j).y/size)].h);
                }

[Layl]

There is no way for us to see the problem without the full picture. As well keep in mind multiple lines are your friend. It's easier to see a problem with your code when it's not all stuffed into a single line.

[tanner bananer]

There is no way for us to see the problem without the full picture. As well keep in mind multiple lines are your friend. It's easier to see a problem with your code when it's not all stuffed into a single line.

well that long draw function's perfectly functional rn. i guess i'll try n find it out myself.

[tanner bananer]

I'm a dingus the problem was they were all on my ip so it only sent me the data once 

[Sik]

So, it was identifying them by the IP address, not by the socket? (this can bring issues in the future, e.g. two computers under the same router may appear as the same IP address to outsiders)

[tanner bananer]

So, it was identifying them by the IP address, not by the socket? (this can bring issues in the future, e.g. two computers under the same router may appear as the same IP address to outsiders)

nah I'm using sockets and identifying by username which is proly inefficient but eh we tested it and had it functioning in my comp sci class n we were all in the same room on the same router

[Cheezmeister]

I would just like to say that I love this thread's title and also μηκοοι's handle.

[Sik]

we tested it and had it functioning in my comp sci class n we were all in the same room on the same router

Within the same router you will all see your addresses before they get changed by the router. I meant situations like two siblings in the same house (thereby the same router) playing with other people (who will see their external addresses since they aren't under the same network).

Identifying by username is not that slow if you hash the strings (not even something complex, just quickly adding all the bytes will do the job). Then you can easily rule out when an username isn't the one you want by doing a quick integer comparison before checking the full string =P (hash clashes can happen, but you will still avoid most of the string checks, which is the idea)