next »

[jabcog]

Hi everyone

I'm kinda new to coding and have picked up a game jam game my friends and I worked on (I did the art) and I'm trying to add a little bit of code that adjusts the animation speed depending on which animation cycle is playing.

At the moment the code looks like this:

Code:

if (xspd == 0)
{
    image_speed = 0.2;
}
else
{
    image_speed = 0.3;
}

But if I add this simple if statement above it and indent it, the animation starts playing 10x faster, looks buggy and doesn't actually respect the values in the code. Here it is:

Code:

if image_index = walk_sprite {
    if (xspd == 0)
    {
        image_speed = 0.2;
    }
    else if (xspd > 0)
    {
        image_speed = 0.3;
    }
}

Does anyone have an idea what might be causing this?

[alvarop]

I haven't touched game maker in a while so i might be wrong but doesn,t image_index just refer to a specific frame ?

[Grhyll]

Never touched Game Maker at all, but shouldn't the comparison in your first if be "==" instead of a single "="?

[jabcog]

Grhyll I might be wrong but I think game maker reads them both the same. I tried it out and it didn't make any difference.

Thanks alvarop! Yeah it does... I changed it to sprite_index which it should have been and it's definitely working more like I was expecting, eg when it's moving the speed of the animation plays faster.

One thing though, but I think this is more of a generic programming question rather than game maker specific, is that the animation is playing faster as soon as the character is moving faster than 0 instead of only when 'walking_sprite' is playing. Can you see anything in the code that might be causing that? Maybe I'm not using the right commands in the if statement?

This is what I've got:

Code:

if sprite_index = walk_sprite {
    if (xspd == 0)
    {
        image_speed = 0.2;
    }
    else
    {
        image_speed = 1;
    }
}

[alvarop]

Maybe there's some conflict with the other animations you have? Is that all the code you have related to animations?

Try using the "and" operator (not sure what it is in GML anymore, maybe && ?) and check for both speed and animation at the same time. Just to check and let me know if that works.

[jabcog]

Alvarop, I went through all of the code and made sure that image_speed wasn't being set anywhere else. I did find that the during the Create event the idle image sequence had a slower rate than what I was wanting and then continued to play around with what I was actually wanting to code.

After a bit of trial and error I realised that what I was trying to do wasn't even going to be visible since in the previous examples when xspd = 0 idle is played and then when it's > 0 it was at full speed which didn't make sense at all.. :p

Anyways, here's what I've ended up with. I don't know if its bad to have two if statements without an else but it seems to work. Is that okay?

Code:

if sprite_index = walk_sprite {
    if (xspd < 1.5){
    image_speed = 0.2;
    }
    
    if (xspd > 1.5){
    image_speed = 1;
    }
}

[alvarop]

Alvarop, I went through all of the code and made sure that image_speed wasn't being set anywhere else. I did find that the during the Create event the idle image sequence had a slower rate than what I was wanting and then continued to play around with what I was actually wanting to code.

After a bit of trial and error I realised that what I was trying to do wasn't even going to be visible since in the previous examples when xspd = 0 idle is played and then when it's > 0 it was at full speed which didn't make sense at all.. :p

Anyways, here's what I've ended up with. I don't know if its bad to have two if statements without an else but it seems to work. Is that okay?

Code:

if sprite_index = walk_sprite {
    if (xspd < 1.5){
    image_speed = 0.2;
    }
    
    if (xspd > 1.5){
    image_speed = 1;
    }
}

Hehe, there you go. I don't wanna give you bad advice, but for now, I think you should worry about making things work the way you want them, for you, and not necessarly doing things "the best way" (which a lot of people have been telling me : there is no right way to do things, only "your" way).

So, if it works, you're doing it the right way
Learn about else if if you really want to change it up a bit more.

[jabcog]

Cheers. I'll look into it

[emptyfortress]

Just wanted to say that it's perfectly OK to have if statements without an else clause, or nested if statements. As long as it does what you want it to do and it's readable for you it's fine

[jabcog]

  thanks emptyfortress.